fix: iterate lower bound may panic if search with the same prefix on keys#35
Closed
absolute8511 wants to merge 1 commit intohashicorp:masterfrom
Closed
fix: iterate lower bound may panic if search with the same prefix on keys#35absolute8511 wants to merge 1 commit intohashicorp:masterfrom
absolute8511 wants to merge 1 commit intohashicorp:masterfrom
Conversation
|
|
Contributor
|
Thanks you so much @absolute8511 for this PR. I've included fixes for these panics as part of fixing a bunch of other bugs in #39. One of those other fixes is the same panic bug that exists in I'll close this PR in favour of the more complete one, but your effort in finding and fixing this with tests is very much appreciated, Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should fix the issue #28