Retrieve checksum from subfolder/filename#239
Merged
sylviamoss merged 5 commits intov2from Mar 18, 2020
Merged
Conversation
mildwonkey
approved these changes
Mar 17, 2020
mildwonkey
left a comment
There was a problem hiding this comment.
Looks good to me!
I ran terraform's test locally against this branch for good measure, no concerns here :)
This was referenced Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation to retrieve a checksum from a file based on a subfolder + filename. For example:
Iso checksum file contains both below, differing only by the subfolder.
The checksummed path is http://archive.ubuntu.com/ubuntu/dists/bionic-updates/main/installer-amd64/current/images/netboot/mini.iso
We then verify wich checksum filename is contained by the checksummed path if none of the previous options was valid.
This is motivated by issue hashicorp/packer#8774