NET 6318 - Go/Terraform Version Upgrade + E2E passing#1071
NET 6318 - Go/Terraform Version Upgrade + E2E passing#1071asheshvidyut merged 33 commits intomainfrom
Conversation
9772185 to
ba0c913
Compare
| // check scheduled task did not trigger immediately and ran only on schedule | ||
| api.WaitForEvent(t, cts, taskName, registerTime, scheduledWait) | ||
| checkScheduledRun(t, taskName, registerTime, taskSchedule, port) | ||
| time.Sleep(defaultWaitForTestReadiness) |
There was a problem hiding this comment.
Had to add this and the same one below this to make the E2E test pass.
Will this be because of #1067 ?
There was a problem hiding this comment.
Most likely! This is fine in the short term to get the release back on track, but could you follow up later and add a more dynamic wait? Like in validateService, keep checking for the expected state with more of a polling mechanism.
There was a problem hiding this comment.
Also might be better to have a shorter wait that's closer to the delay you added. So maybe 15 seconds instead of 30 seconds. But not a big deal right now since you're trying to release.
mkam
left a comment
There was a problem hiding this comment.
LGTM. You'll also need to add entries in the changelog for the go version upgrade and the Terraform support either in this PR or in a follow up PR.
Bump Go Version - 1.20.10
Updated Terraform Version - 1.6.2
Make E2E tests passing