Security Fix: Prevent ParseTemplateConfig panic on malformed input#2099
Merged
santoshpulluri merged 1 commit intomainfrom Oct 16, 2025
Merged
Security Fix: Prevent ParseTemplateConfig panic on malformed input#2099santoshpulluri merged 1 commit intomainfrom
santoshpulluri merged 1 commit intomainfrom
Conversation
sanikachavan5
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a security vulnerability in
ParseTemplateConfigwhere certain malformed inputs could cause a runtime panic due to improper handling of empty regex matches.Problem
The function
ParseTemplateConfigwas vulnerable to runtime panics when processing inputs like:or:::. The regular expressionconfigTemplateRe.FindAllString(s, -1)would return an empty slice for such inputs, but thedefaultcase in the switch statement assumedparts[0]andparts[1]would always exist, causing an "index out of range" panic.Solution
case 0:to handle empty parts slices and returnErrTemplateStringEmpty:and:::Security Impact
Changes
config/template.go: Added case 0 handling in ParseTemplateConfig switch statementconfig/template_test.go: Added test cases for "colon_only" and "multiple_colons_only" scenariosTesting
References