ci: fix test splits that have less test packages than runner count from hanging#17080
Merged
ci: fix test splits that have less test packages than runner count from hanging#17080
Conversation
…rix size is smaller than total_runners, use the smaller number
loshz
reviewed
Apr 20, 2023
Contributor
loshz
left a comment
There was a problem hiding this comment.
Just the one comment about the push trigger. The rest are non-blocking syntactic bash NITs.
Co-authored-by: Dan Bond <danbond@protonmail.com>
loshz
approved these changes
Apr 21, 2023
This was referenced Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In 1.13, there are only two compatibility test packages. So when a generate matrix job has a TOTAL_RUNNERS of 5 but there are only 2 packages, the process hangs. This PR changes the runner count to 2 in this case.
Another issue that occurs that is fixed in this PR is that when you specify TOTAL_RUNNERS = 4, you will actually split across 5 runners. (The same occurs with any number you set TOTAL_RUNNERS to. You will actually get 1 greater.)