Backport of docs: Migrate link formats into stable-website#16061
Merged
im2nguyen merged 2 commits intostable-websitefrom Feb 9, 2023
Merged
Conversation
91d2f07 to
65877fb
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
github-team-consul-core-pr-approver
approved these changes
Jan 25, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
Contributor
|
Closing, we are waiting until the next release in february to align the latest link rewrites with |
im2nguyen
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15976 to be assessed for backporting due to the inclusion of the label type/docs-cherrypick.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
What
.github/workflows/check-legacy-links-format.yml- This is a workflow that checks if links in markdown content are in the new format. It does this by running the link rewrite script fromdev-portal, and then asserting that no "rewriteable" links were found. This workflow will be used on subsequent PRs to maintain the new link format..github/workflows/test-link-rewrites.yml- This is a workflow that executes e2e tests of this PR's changes against themainbranch's deploy preview. The tests only run for branches nameddocs/amb.migrate-link-formats, so future PRs will not have the tests run against them. This is a temporary workflow.PRs that came before this as pre-work
Reviewing
With the two new workflows in place, this PR should only need a spot-check.
Testing
Overview of commits