Issue #99: the package can't be installed and imported correctly in colab #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or installation so that it can run on google colab
Contributor
Author
|
This is a work in progress — I haven't tested the harmonydata API yet. |
…supported go from 3.9 to 3.13.3, and across all python versions supported the package fails only 1 test from 68
Contributor
|
Thanks Brandon - is it still a work in progress? |
Contributor
Author
|
I couldn't test the Harmony API because it has problems too; I'd have to fork it and correct the same issues. However, I managed to make it work for versions 3.9 to 3.13 with the same error I reported. I haven't had time to fix the API import errors yet, but some of them should be fixed by changing the package versions in the |
Contributor
|
Thanks for the clarification @brandonHaipas . I have made a corresponding issue in the API repo here: harmonydata/harmonyapi#22 - so when someone has time they can pick that up and bring the API in line with your fork. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #99 fix. There are still tests to pass.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Testing
I used all the tests provided by the repo using
tox, first with a specific python version (3.11) and then with versions 3.8 to 3.11.tox. For tox to work on your machine you have to install all python versions specified intox.inieither with pyenv in linux or other environment manager of your preference.Since the Harmony Python package is used by the Harmony API (which is itself used by the R library and the web app), we need to avoid making any changes that break the Harmony API. Please also run the Harmony API unit tests and check that the API still runs with your changes to the Python package: https://github.com/harmonydata/harmonyapi
Test Configuration
Checklist
requirements.txt,pyproject.tomland also in therequirements.txtin the API repoOptionally: feel free to paste your Discord username in this format:
discordapp.com/users/yourIDin your pull request description, then we can know to tag you in the Harmony Discord server when we announce the PR.