Merged
Conversation
26 tasks
RazrFalcon
requested changes
Feb 7, 2021
src/buffer.rs
Outdated
| @@ -1,4 +1,5 @@ | |||
| use std::convert::TryFrom; | |||
| use alloc::{string::String, vec::Vec}; | |||
| use core::{convert::TryFrom, fmt, mem}; | |||
Collaborator
There was a problem hiding this comment.
I would like to keep core:: everywhere.
Contributor
Author
There was a problem hiding this comment.
I'm not sure what you mean with that. You mean without the { } or what?
Contributor
Author
There was a problem hiding this comment.
Oh you mean without importing the modules?
Collaborator
There was a problem hiding this comment.
Yes. Do not use use for core. alloc is fine.
Turns out that supporting no_std is pretty trivial, so here are the changes necessary for that.
Collaborator
|
Thanks. |
Contributor
Author
|
Thank you as well :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that supporting no_std is pretty trivial, so here are the changes necessary for that.