Make buffer.serialize() flag names consistent with buffer.setFlags()#160
Merged
khaledhosny merged 2 commits intomainfrom Feb 3, 2026
Merged
Make buffer.serialize() flag names consistent with buffer.setFlags()#160khaledhosny merged 2 commits intomainfrom
khaledhosny merged 2 commits intomainfrom
Conversation
fe219ef to
4b25459
Compare
buffer.setFlags() accepts upper case names similar to HarfBuzz C API, so make the new buffer.serialize() do the same for consistency.
ad10120 to
433e4e2
Compare
433e4e2 to
ef60601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffer.setFlags() accepts upper case names similar to HarfBuzz C API, so make the new buffer.serialize() do the same for consistency.