[gsubgpos] Guard integer arithmetic against wrapping below zero#4934
Merged
behdad merged 1 commit intoharfbuzz:mainfrom Nov 28, 2024
Merged
[gsubgpos] Guard integer arithmetic against wrapping below zero#4934behdad merged 1 commit intoharfbuzz:mainfrom
behdad merged 1 commit intoharfbuzz:mainfrom
Conversation
Member
Author
|
@khaledhosny Is Circle just mad that I opened this PR from my fork instead of the org repo? |
Collaborator
May be you didn’t give it the required permissions on your personal account? |
When either casting a signed integer to an unsigned one or subtracting a value from an unsigned one, add assertions to verify we will not end up below expected bounds.
8c7bc63 to
1d1bfc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When either casting a signed integer to an unsigned one or subtracting a value from an unsigned one, add assertions to verify we will not end up below expected bounds.
This tracks the extra assertions added to Rustybuzz in harfbuzz/rustybuzz#146 subsequent to having found a bogus type casting in the Rust port via harfbuzz/rustybuzz#142.