BUILD/MINOR: ci: add extra job to indicate if someone used revive override

oktalz · oktalz · commit 77b9d4fa8e36 · 2026-01-14T15:37:16.000+01:00
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -19,6 +19,7 @@ variables:
 include:
   - local: .gitlab/bots.yml
   - local: .gitlab/diff.yml
+  - local: .gitlab/diff-warnings.yml
   - local: .gitlab/lint.yml
   - local: .gitlab/unit-tests.yml
   - local: .gitlab/build.yml
diff --git a/.gitlab/diff-warnings.yml b/.gitlab/diff-warnings.yml
@@ -0,0 +1,43 @@
+check-revive-flags:
+  stage: diff
+  allow_failure: true
+  rules:
+    - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
+  image:
+    name: $CI_REGISTRY_GO/golang:$GO_VERSION
+    entrypoint: [ "" ]
+  tags:
+    - go
+  script:
+    - git fetch origin ${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}
+    # Parse the diff to find 'revive:disable' and track file/line info
+    - |
+      git diff -U0 origin/${CI_MERGE_REQUEST_TARGET_BRANCH_NAME}...HEAD | perl -ne '
+        if (/^\+\+\+ b\/(.*)/) { $file = $1; }
+        if (/^@@ -\d+(?:,\d+)? \+(\d+)(?:,(\d+))? @@/) { $line = $1; }
+        if (/^\+(.*revive:disable.*)/) {
+          print "$file:$line:$1\n";
+          $line++;
+        } elsif (/^\+/) {
+          $line++;
+        }
+      ' > found_disables.txt || true
+
+    - |
+      if [ -s found_disables.txt ]; then
+        echo "⚠️ Found 'revive:disable' in the following locations:"
+        cat found_disables.txt
+
+        DESCRIPTION=$(cat found_disables.txt)
+        junit-report add --status=failed --file=revive-check --message="revive:disable found" --description="$DESCRIPTION"
+        exit 1
+      else
+        echo "✅ No 'revive:disable' tags found in the diff."
+        junit-report add --status=ok --file=revive-check --message="clean" --description="No linter disables found."
+      fi
+  artifacts:
+    when: always
+    paths:
+      - junit-report.xml
+    reports:
+      junit: junit-report.xml
