Pass request to global context function when available#81
Merged
jagoda merged 1 commit intohapijs:masterfrom Apr 4, 2016
Merged
Pass request to global context function when available#81jagoda merged 1 commit intohapijs:masterfrom
jagoda merged 1 commit intohapijs:masterfrom
Conversation
Contributor
Author
|
@g6123 what do you think? Would this work for you? |
wswoodruff
reviewed
Dec 29, 2017
| }); | ||
|
|
||
| it('returns a promise when no options or callback given (server)', () => { | ||
| it('does not pass the request to the global context function (server)', (done) => { |
Contributor
There was a problem hiding this comment.
What's the reasoning behind this test? issue #115 asking to have the request object available to the global context when using request.render
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #59.