Load partials and helpers before compile if isCached is false#132
Merged
wswoodruff merged 4 commits intomasterfrom Nov 17, 2017
Merged
Load partials and helpers before compile if isCached is false#132wswoodruff merged 4 commits intomasterfrom
wswoodruff merged 4 commits intomasterfrom
Conversation
Contributor
Author
|
Added tests, and bust |
eb39ad0 to
d7267d4
Compare
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change? If isCached is false, then users expect there to be changes when the file on disk changes. Build tools like
BrowserSyncalso reload when files on disk change, so this adds a lot of 'it just works' valueFeedback welcome!