Add globals introduce in Node.js v14.6.0#981
Merged
cjihrig merged 1 commit intohapijs:masterfrom Jul 21, 2020
Merged
Conversation
Lab is currently reporting leaked globals on v14.6.0 for `FinalizationRegistry` and `WeakRef`. The test suite is also failing on v14.5.0. With this change lab will no longer fail any test suite run on v14.6.0, it also fixes broken tests with lab on v14.5.0.
cjihrig
approved these changes
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab is currently reporting leaked globals on v14.6.0 for
FinalizationRegistryandWeakRef. The test suite is also failingon v14.5.0. With this change lab will no longer fail any test suite run
on v14.6.0, it also fixes broken tests with lab on v14.5.0.