Skip to content

Add IP Address Validation#458

Closed
DavidTPate wants to merge 1 commit intohapijs:masterfrom
DavidTPate:ip-support
Closed

Add IP Address Validation#458
DavidTPate wants to merge 1 commit intohapijs:masterfrom
DavidTPate:ip-support

Conversation

@DavidTPate
Copy link
Contributor

This Pull Request adds functionality for validating strings either as a generic IP address (IPv4 (CIDR optional), IPv6 (CIDR optional), or IPvFuture). The validation is done off of the related RFCs (RFC 791 (IPv4) RFC 4291 (IPv6) and RFC 4632 (CIDR)) and provides the standard error messages to the library.

…sses, all IPv4 (CIDR optional) Address, all IPv6 (CIDR optional) address, and all IPvFuture addresses
@Marsup Marsup added the feature New functionality or improvement label Nov 3, 2014
@Marsup
Copy link
Collaborator

Marsup commented Nov 3, 2014

There's a policy in hapi projects not to depend on sub 1.x dependencies.
Why didn't you try to contribute to ip ?

@Marsup Marsup self-assigned this Nov 3, 2014
@DavidTPate
Copy link
Contributor Author

No particular reason why I didn't contribute, I had taken a look through some of the other validation modules and noticed that in general they were not very supportive of the various specifications around IP addresses.

I understand the policy you mentioned, I'll look into contributing to the ip module. Barring that I'll see about adding additional tests and documentation to where I feel confident in calling the library a version 1.0.

@rlidwka
Copy link

rlidwka commented Nov 3, 2014

that in general they were not very supportive of the various specifications around IP addresses.

Other validation modules usually have support for custom functions, where you can add ip validation as a plugin.

@Marsup
Copy link
Collaborator

Marsup commented Mar 14, 2015

@DavidTPate do you think we could do the same work here as uri ?

@DavidTPate
Copy link
Contributor Author

@Marsup Yeah, that's what I was planning to do next. It looks like I lost that branch at some point. So I'll close this PR and take of it in another one once I have it done.

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants