fix: allow NaN in schema describe() output validation#3103
Merged
Marsup merged 1 commit intohapijs:masterfrom Mar 23, 2026
Merged
fix: allow NaN in schema describe() output validation#3103Marsup merged 1 commit intohapijs:masterfrom
Marsup merged 1 commit intohapijs:masterfrom
Conversation
When a schema includes .allow(NaN), calling .describe() would throw a ValidationError because NaN was not listed as a valid item type in the internal manifest values schema. NaN is a valid JavaScript number and a legitimate value to allow in a joi schema. The fix adds NaN alongside the existing Infinity and -Infinity exceptions in the internals.desc.values definition. Fixes hapijs#3094
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
.describe()on a schema that includes.allow(NaN)throws a ValidationError.The issue is in
internals.desc.valuesinlib/schemas.js—Infinityand-Infinityare listed as allowed number values, butNaNis not, so the describe output fails its own internal validation.Adding
NaNto the list fixes it. All existing tests still pass.Fixes #3094