fix: domain default tld validation#3015
Merged
Marsup merged 4 commits intohapijs:masterfrom Jan 29, 2024
Merged
Conversation
Nargonath
reviewed
Jan 24, 2024
Member
Nargonath
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have some comments.
Author
|
hey @Nargonath, thanks for the review! i've made some changes based on your suggestions. |
Marsup
reviewed
Jan 29, 2024
Collaborator
|
Nice catch, I'll backport to v17 myself as master is currently the pending v18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3007
Methods
Joi.string().domain()andJoi.string().email()are now correctly set to default totlds: { allow: true }, as documented.