Skip to content

feat: Improve alternatives type#2981

Merged
Marsup merged 5 commits intohapijs:masterfrom
felixmosh:improve-alternative-types
Oct 4, 2023
Merged

feat: Improve alternatives type#2981
Marsup merged 5 commits intohapijs:masterfrom
felixmosh:improve-alternative-types

Conversation

@felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Aug 24, 2023

closes #2980

Before

image

After

image

with different types
image

with try
image

with conditional
image

image

@felixmosh felixmosh force-pushed the improve-alternative-types branch 2 times, most recently from d2be019 to ecb1bf4 Compare August 24, 2023 13:15
@felixmosh felixmosh force-pushed the improve-alternative-types branch from aae134d to 1d243f3 Compare September 4, 2023 11:28
@Marsup Marsup self-assigned this Oct 4, 2023
@Marsup Marsup added the types TypeScript type definitions label Oct 4, 2023
@Marsup Marsup added this to the 18.0.0 milestone Oct 4, 2023
@Marsup Marsup force-pushed the improve-alternative-types branch from 1d243f3 to 0fb1126 Compare October 4, 2023 15:05
@Marsup Marsup merged commit 6dbe77d into hapijs:master Oct 4, 2023
@Marsup
Copy link
Collaborator

Marsup commented Oct 4, 2023

Thanks a lot for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

types TypeScript type definitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Types of alternative are wrong always resolves to any

2 participants