Skip to content

Associate Buffer with BinarySchema#2961

Merged
Marsup merged 1 commit intohapijs:masterfrom
jpage-godaddy:binary-schema-typings
Aug 27, 2023
Merged

Associate Buffer with BinarySchema#2961
Marsup merged 1 commit intohapijs:masterfrom
jpage-godaddy:binary-schema-typings

Conversation

@jpage-godaddy
Copy link
Contributor

@jpage-godaddy jpage-godaddy commented Jun 29, 2023 •
edited
Loading

This fixes the ability do have types like:

type Photo = {
  id: number,
  caption: string,
  content: Buffer
};

const schemaProps: SchemaMap<Photo, true> = {
  id: Joi.number(),
  caption: Joi.string(),
  content: Joi.binary()
};

@Marsup Marsup self-assigned this Aug 27, 2023
@Marsup Marsup added the types TypeScript type definitions label Aug 27, 2023
@Marsup Marsup added this to the 17.10.0 milestone Aug 27, 2023
@Marsup Marsup merged commit 19dbe8f into hapijs:master Aug 27, 2023
@Marsup
Copy link
Collaborator

Marsup commented Aug 27, 2023

Thanks!

@jpage-godaddy jpage-godaddy deleted the binary-schema-typings branch August 28, 2023 17:31
@Nargonath Nargonath mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Marsup Marsup

Labels

types TypeScript type definitions

Projects

None yet

Milestone

17.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jpage-godaddy @Marsup