Bug Hunt: valid IPv6 domain literals in email addresses fail validation#288
Closed
andris9 wants to merge 1 commit intohapijs:masterfrom
Closed
Bug Hunt: valid IPv6 domain literals in email addresses fail validation#288andris9 wants to merge 1 commit intohapijs:masterfrom
andris9 wants to merge 1 commit intohapijs:masterfrom
Conversation
Contributor
|
Thanks for the report. This was fixed via an earlier bug hunt report which clearly showed just how sad our previous email regex was. Because the code we had was so poorly done for email verification, I just replaced the whole thing with another module which should clear all these other email bug reports. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validating e-mail addresses is a compromise between all the various RFCs and real world, so I do not mind if you disregard this as not a bug.
RFC5321 defines domain literals that can be used instead of hostnames in the e-mail address. While you seem to pass IPv4 addresses in the form of
user@[127.0.0.1], joi does not recognize IPv6 format which is a bit different, namelyuser@[IPv6:zzz]wherezzzis a valid IPv6 address, using either full or compact syntax.Output for validating such address: