Skip to content

fix: better unsafe check of exponential numbers#2867

Merged
Marsup merged 1 commit intomasterfrom
fix/exponential-numbers
Oct 22, 2022
Merged

fix: better unsafe check of exponential numbers#2867
Marsup merged 1 commit intomasterfrom
fix/exponential-numbers

Conversation

@Marsup
Copy link
Collaborator

@Marsup Marsup commented Oct 22, 2022

Fixes #2542.
Fixes #2672.

This method is borrowed from https://github.com/josdejong/lossless-json, big kudos to him!

@Marsup Marsup added the bug Bug or defect label Oct 22, 2022
@Marsup Marsup self-assigned this Oct 22, 2022
@Marsup Marsup added this to the 17.7.0 milestone Oct 22, 2022
@Marsup Marsup merged commit 0f936dd into master Oct 22, 2022
@Marsup Marsup deleted the fix/exponential-numbers branch October 22, 2022 17:42
This was referenced Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug or defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some exponential notation strings are validated as unsafe numbers Number validation fails on some strings with E-notation

1 participant