fix: do not confuse booleans for alernatives in strict mode#2850
Closed
fix: do not confuse booleans for alernatives in strict mode#2850
Conversation
3bae8a1 to
e5bdce4
Compare
Nargonath
approved these changes
Sep 29, 2022
Member
Nargonath
left a comment
There was a problem hiding this comment.
LGTM.
One question though for my own understanding, is the second generic parameter U used to keep the original value of T since T will be narrowed down by the conditional type so we can compare T to its original value after it's been narrowed?
Collaborator
Author
|
Explanation is in https://stackoverflow.com/a/59687759. Closing in favor of #2851. |
Member
|
Thanks @Marsup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2848