Add isPresent option to object dependencies#2762
Merged
Marsup merged 6 commits intohapijs:masterfrom Oct 22, 2022
Merged
Conversation
Collaborator
|
Hi, Just wondering, do you actually need a function for that? I mean, it looks more flexible, but it could as well be a flag that also checks for null values. I don't know if presence can or should be defined by any other keyword. |
Contributor
Author
|
I prefer the extra flexibility of a function, but i could go either way really... If this ever gets reviewed that is 😅 |
b7b79d7 to
1e94298
Compare
00d0d14 to
1c4a71d
Compare
Collaborator
|
I've changed a bit the implementation but it should be good now. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed a feature such as in this StackOverflow question.
When you have a schema such as:
You may want
schema.validate({})to pass, however, currently this will fail because theoxorrule will resolveaandbtonull, and the current check is againstundefined.This PR adds a new option,
isPresent, that allows for something like:In this case, the
oxor(or any of the other dependency options, such asxororand) will acceptundefinedandnullvalues as empty.