fix for stripUnknown not working for nested object on invalid object#2518
Merged
hueniverse merged 1 commit intohapijs:masterfrom Feb 8, 2021
Merged
Conversation
|
Hey Just wanted to say I am also blocked by this issue on a project that is supposed to be released in a few days (we've fixed it with a hefty amount of JS to re-structure the objects but it would be amazing to get Joi to do it for us since it's fully aware of the schema). This PR has been waiting for a while and seems to be fixing two issues, is it possible to review it? perhaps have I missed something that may block merging it? Thanks everyone |
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2479
Fixes #2459