Added support for buffer length#191
Closed
martinheidegger wants to merge 19 commits intohapijs:masterfrom
Closed
Conversation
utf-8 strings can have 1 and 2 byte characters. Some - if not many - systems have a byte limit, not a length limit thus it might be important to actually set the byte limit. I added three methods that should offer this possibility.
Contributor
|
I am not sure how useful this is, but I am willing to consider adding a single method |
Contributor
Author
|
I think I messed up the git structure (very sorry for that). Can you use the patch still? |
Contributor
|
Can you bring this up to speed with the current master branch? Might be easier to manually do a new pull request than keep patching this one, using the existing work. |
Contributor
|
Also, doesn't this require specifying an encoding format to calculate bytes size? |
Contributor
|
Decided to implement as an attribute of the existing rules. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utf-8 strings can have 1 and 2 byte characters. Some - if not many - systems have a byte limit, not a length limit thus it might be important to actually set the byte limit. I added three methods that should offer this possibility.