Don't delete object key when it equals the rename.to in a rename with regex#1770
Closed
paixaop wants to merge 1 commit intohapijs:masterfrom
Closed
Don't delete object key when it equals the rename.to in a rename with regex#1770paixaop wants to merge 1 commit intohapijs:masterfrom
paixaop wants to merge 1 commit intohapijs:masterfrom
Conversation
…ed the original key to be deleted if rename.options.alias was false
Closed
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separating out the rename fix from the
keysToLowerCaseDescription copied from original pull request #1763, for easier reference.
Calling rename with a regex where the key matches the
rename.tocauses the key to get deleted from the object.Example: I use the folllowing schema to validate an AWS x-api-key header:
Using rename to force a value such as 'X-ApI-KeY' to be all lower case, and therefore normalizing it to 'x-api-key'.
The bug is when the header is already all lower case 'x-api-key', the
rename.fromis the same asrename.toso it gets deleted ifoption.alias = false, leaving the object with nox-api-keyat all.So this: