Thanks :) I'll have a go at the docs

If I moved the ValidationError into lib/errors/ValidationError.js and errors.js into lib/errors/index.js would there be objections? I tend to like classes in their own files.

Wasn't sure what approach to take with the docs, it doesn't seem like a breaking change so I just went with 'mention it somewhere'. Let me know what you had in mind.

If I moved the ValidationError into lib/errors/ValidationError.js and errors.js into lib/errors/index.js would there be objections? I tend to like classes in their own files.

None from me 👍

It shouldn't be a breaking change unless people do things like error.hasOwnProperty('isJoi') but I really don't expect that.

As for the docs, the error type should probably appear next to https://github.com/hapijs/joi/blob/master/API.md#version as it's now exported.

I've add a ValidationError section to the list of exports. I wasn't sure how much I could elaborate without duplicating what's already under Errors. To be honest the error docs could use a proper re-format, but I'll do that in a seperate PR to stop the scope of this creeping.

I've not moved ValidationError into its own module for the same reason. I tried it, but that meant I had to factor out something else, which relied on something else and it just snowballed. I'd like to do it, but I'll do it in a different PR. There's a lot of opportunity for non-functional code quality improvements around the errors as well, which I'll do at the same time.

Are there any other changes I should make to this PR? Are the docs OK?

Nope, that's perfect, just a few details to sort out to decide in which release to include this, I'll merge in a bit.

Out of safety I'm going to set this one for v15 even though I don't personally consider it a breaking change.

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.