Skip to content

Remove flatten arguments. Closes #1644#1646

Closed
hueniverse wants to merge 1 commit intov15from
1644
Closed

Remove flatten arguments. Closes #1644#1646
hueniverse wants to merge 1 commit intov15from
1644

Conversation

@hueniverse
Copy link
Contributor

@hueniverse hueniverse commented Nov 12, 2018

No description provided.

@hueniverse hueniverse added the breaking changes Change that can breaking existing code label Nov 12, 2018
@kanongil
Copy link
Contributor

kanongil commented Nov 12, 2018

The Utils.verifyFlat() usage seems excessive. Many methods now no longer allows array arguments.

Eg. for any.allow() you documented it as accepting any type, but it will now throw on an array. The old implementation accepted this, provided it was encapsulated in another array: any.allow([[1, 2, 3]]).

@hueniverse
Copy link
Contributor Author

hueniverse commented Nov 12, 2018

Utils.verifyFlat() is a temporary measure to help people migrate. The plan is to drop it after the migration.

I will fix the issue with any.allow().

@Marsup Marsup force-pushed the master branch 2 times, most recently from 4a2de06 to a9aa3e7 Compare November 19, 2018 21:17
@Marsup Marsup added this to the 15.0.0 milestone Nov 19, 2018
@Marsup Marsup changed the base branch from master to v15 November 19, 2018 22:20
Marsup
Marsup reviewed Nov 19, 2018
View reviewed changes
API.md

Adds an alternative schema type for attempting to match against the validated value where:
- `schema` - an array of alternative **joi** types. Also supports providing each type as a separate argument.
- `schema` - a single or an array of alternative **joi** types.
Copy link
Collaborator

@Marsup Marsup Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not choose a spread for this one?

Copy link
Contributor Author

@hueniverse hueniverse Nov 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match the [] format. I wanted it to mirror object().keys({})

@hueniverse hueniverse closed this Apr 2, 2019
@hueniverse hueniverse deleted the 1644 branch May 28, 2019 06:57
@hueniverse hueniverse self-assigned this Jun 16, 2019
@hueniverse hueniverse added the v16 label Aug 10, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Marsup Marsup Marsup left review comments

Assignees

@hueniverse hueniverse

Labels

breaking changes Change that can breaking existing code

Projects

None yet

Milestone

16.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@hueniverse @kanongil @Marsup