Add an object.append() method. Fixes #1381.#1435
Merged
Marsup merged 1 commit intohapijs:masterfrom Mar 9, 2018
darknode:master
Merged
Add an object.append() method. Fixes #1381.#1435Marsup merged 1 commit intohapijs:masterfrom darknode:master
Marsup merged 1 commit intohapijs:masterfrom
darknode:master
Conversation
WesTyler
suggested changes
Feb 14, 2018
Contributor
WesTyler
left a comment
There was a problem hiding this comment.
What does this add in addition to the existing .keys()?
Also, is there an issue where this addition was discussed? Any details you can add to the PR to give us insight into why this might be useful or necessary?
Contributor
|
Got an issue linked, comment no longer stands :) |
Contributor
Author
|
Sorry, issue should be linked by it's id. #1381 |
Contributor
|
Ah-ha! Well that certainly changes everything :) |
WesTyler
approved these changes
Feb 14, 2018
Collaborator
|
Thanks ! |
Contributor
|
This is basically an alias for |
Collaborator
|
See linked issue a couple comments above. |
Contributor
|
So basically, but safer 🙅✨ nice! |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.