Skip to content

Fixes : Validate port numbers #1346#1419

Closed
mrveera wants to merge 1 commit intohapijs:masterfrom
mrveera:master
Closed

Fixes : Validate port numbers #1346#1419
mrveera wants to merge 1 commit intohapijs:masterfrom
mrveera:master

Conversation

@mrveera
Copy link

@mrveera mrveera commented Feb 3, 2018

No description provided.

@Marsup Marsup self-assigned this Feb 3, 2018
@Marsup Marsup added the feature New functionality or improvement label Feb 3, 2018
@Marsup
Copy link
Collaborator

Marsup commented Feb 3, 2018

Thanks for the PR, but as stated in the issue, I don't want it to be a wrapper of other joi methods, have it be a classical rule like all others. Also checks the boundaries of it in the tests. And if you could add some documentation that would be great !

@rkt2spc
Copy link
Contributor

rkt2spc commented Mar 11, 2018

@veera83372 Are you still following up on this? I can take it up if you don't have time.

@Marsup
Copy link
Collaborator

Marsup commented Mar 11, 2018

Replaced by #1452.

@Marsup Marsup closed this Mar 11, 2018
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants