Asserts that two arguments are provided to object.with() and object.without()#1395
Merged
Marsup merged 2 commits intohapijs:masterfrom Jan 19, 2018
davidjamesstone:master
Merged
Asserts that two arguments are provided to object.with() and object.without()#1395Marsup merged 2 commits intohapijs:masterfrom davidjamesstone:master
Marsup merged 2 commits intohapijs:masterfrom
davidjamesstone:master
Conversation
Collaborator
|
This method is fine as well, I'd only change the tests. |
Author
|
I agree that form is better. I was originally following the pattern used in the |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How does this look?
The assertion is for arguments.length === 2 rather than arguments.length <= 2 like you suggested (extra arguments).