Update dependencies. Update codebase to ES6/Node4#51
Closed
escalant3 wants to merge 3 commits intohapijs:masterfrom
Closed
Update dependencies. Update codebase to ES6/Node4#51escalant3 wants to merge 3 commits intohapijs:masterfrom
escalant3 wants to merge 3 commits intohapijs:masterfrom
Conversation
lib/directory.js
Outdated
Contributor
There was a problem hiding this comment.
We're also not memoizing the length anymore unless necessary.
Contributor
|
Thanks – merged in cbab9fc. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been exploring the Hapi codebase recently and I noticed
inertwas not ES6 ready. This PR should comply with all the requirements specified in #49The linter was complaining about lots of things that were fixed:
arguments, too bad the rest operator is not available).usestrict andconstalways that it's possible.letonly in mutable casespackage.jsondependencies matching those inhapi/package.jsonelseshould not be in the same line where the previousifclosesQuestions:
4.0.0. But I am not sure how the Hapi team deals with versions.+=. I could do it if needed.Thanks for such an awesome framework. I hope this helps.
Cheers!