Disallow serving absolute paths from directory handler#160
Merged
Conversation
geek
approved these changes
Aug 30, 2021
Nargonath
approved these changes
Aug 30, 2021
Contributor
|
Nice catch! FYI, this issue will not have been exposed if running behind a standard nginx reverse proxy due to the default We might also want to add an option to hapi to remove such duplicate slashes from the incoming url, and make it default in a future breaking release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the directory handler would properly confine requests to only serve files from the configured
path, it would still accept absolute paths to files within that directory through the route's path param. The directory handler is not intended to serve files using absolute paths, and we'd like to disallow the behavior. Thanks to Ryan Govostes for the report.