Directory listing has broken links#124
Merged
hueniverse merged 3 commits intohapijs:masterfrom Sep 12, 2019
Merged
Conversation
MariiaZimokha
commented
Dec 21, 2018
| } | ||
| }); | ||
|
|
||
| const res = await server.inject('/showindex/'); |
Author
There was a problem hiding this comment.
To see an error, just delete last /
const res = await server.inject('/showindex');
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across with this issue #119.
As was described, when we hit top level path, then links are built incorrectly
"/logstrace_context.log".It's just happening when
stripTrailingSlashis set true or last slash is omitted.We need to be sure when we hit top level path, we have slash at the end of it.
Tests were added and coverage wasn't decreased.