Conversation
|
I got the failed unit test addressed, but now I do not reproduce locally on nodeJS |
|
Where are you seeing these failures on master, and how does this fix them?
Node releases v14.6.0, which introduced new global variables. Previously, |
|
Observed on last master commit: https://travis-ci.org/github/hapijs/hapi/jobs/709295103 On my branch, I consistently get that error + 1 identical one. In the unit test, the started server never receives a request an address that is like |
|
Ok. I just checked my branch, and now I am only getting the leak errors, the timeouts have disappeared: https://travis-ci.org/github/hapijs/hapi/jobs/711594775. Something must have changed recently. But here is a screenshot locally of the failure: Going to try reinstalling my modules to see if problem persists. If not, I'll close this PR. |


No ticket created for this PR. This is a simple update to fix 2 failing unit tests on master. Something must have changed recently because I see valid builds at recent as 8 days ago.