Skip to content

Update 2 failing unit tests#4125

Closed
neenhouse wants to merge 1 commit intohapijs:masterfrom
neenhouse:fix-master-build
Closed

Update 2 failing unit tests#4125
neenhouse wants to merge 1 commit intohapijs:masterfrom
neenhouse:fix-master-build

Conversation

@neenhouse
Copy link
Copy Markdown
Contributor

@neenhouse neenhouse commented Jul 24, 2020

No ticket created for this PR. This is a simple update to fix 2 failing unit tests on master. Something must have changed recently because I see valid builds at recent as 8 days ago.

@neenhouse
Copy link
Copy Markdown
Contributor Author

neenhouse commented Jul 24, 2020

I got the failed unit test addressed, but now The following leaks were detected:FinalizationRegistry, WeakRef.

I do not reproduce locally on nodeJS v12.16.1 or v14.5.0

@cjihrig
Copy link
Copy Markdown
Contributor

cjihrig commented Jul 24, 2020

Where are you seeing these failures on master, and how does this fix them?

I got the failed unit test addressed, but now The following leaks were detected:FinalizationRegistry, WeakRef occurs (not observed locally on nodeJS 12 or 14).

Node releases v14.6.0, which introduced new global variables. Previously, lab didn't know about them, so it reported errors. lab has already been updated - travis is just using a cached version.

@neenhouse
Copy link
Copy Markdown
Contributor Author

Observed on last master commit: https://travis-ci.org/github/hapijs/hapi/jobs/709295103

On my branch, I consistently get that error + 1 identical one. In the unit test, the started server never receives a request an address that is like http://{HOSTNAME}:60962 but http://localhost:60962 seems to get around the issue.

@neenhouse
Copy link
Copy Markdown
Contributor Author

Ok. I just checked my branch, and now I am only getting the leak errors, the timeouts have disappeared: https://travis-ci.org/github/hapijs/hapi/jobs/711594775. Something must have changed recently. But here is a screenshot locally of the failure:

Screen Shot 2020-07-24 at 4 39 13 PM

Going to try reinstalling my modules to see if problem persists. If not, I'll close this PR.

@neenhouse
Copy link
Copy Markdown
Contributor Author

neenhouse commented Jul 24, 2020

Issue was my VPN connection was interfering with host resolution in the unit test. Sorry for the overhead, going to close this one down.

Screen Shot 2020-07-24 at 4 47 45 PM

@neenhouse neenhouse closed this Jul 24, 2020
@neenhouse neenhouse deleted the fix-master-build branch July 24, 2020 21:48
@devinivy devinivy added the non issue Issue is not a problem or requires changes label Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non issue Issue is not a problem or requires changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants