Decorate requests with symbols with apply=true#3996
Merged
hueniverse merged 1 commit intohapijs:masterfrom Dec 28, 2019
Merged
Conversation
Contributor
|
I would probably refactor |
Use map to hold decorations internally. This also fixes a bug where request decorations using Symbols did not work with `apply=true`
Contributor
Author
|
Thanks for the suggestion @kanongil. It simplifies the code greatly! I'm not very familiar with the codebase but I've tried my best at refactoring the internal The test still pass apart from two of them, although they were failing even before this change. |
Contributor
|
It's rare I merge a PR... nicely done. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes a bug where Symbol decorations would not get added to request instances when
{ apply: true }option was used. The issue was caused by iterating over decorations object usingfor...inwhich only iterates over enumerable properties (symbols are not enumerable)Since Symbols are expected property names this PR fixes the issue above by also iterating over known symbol properties using
Object.getOwnPropertySymbols.