Allow reconfiguring after monitor is started#593
Closed
joshdover wants to merge 4 commits intohapijs:masterfrom
Closed
Allow reconfiguring after monitor is started#593joshdover wants to merge 4 commits intohapijs:masterfrom
joshdover wants to merge 4 commits intohapijs:masterfrom
Conversation
This allows consumer apps to reconfigure and restart good's monitor on the fly. This is useful for supporting logrotate (SIGHUPs trigger reopening of files) and supporting on-the-fly configuration changes.
1de519f to
cd5dc7f
Compare
joshdover
commented
Aug 15, 2018
lib/monitor.js
Outdated
| this._server.events.removeListener('response', this._responseHandler); | ||
| // These cannot be removed because Podium does not support unsubscribing from criteria, only event names. | ||
| // this._server.events.removeListener({ name: 'request', channels: ['error'] }, this._errorHandler); | ||
| // this._server.events.removeListener({ name: 'request', channels: ['app'] }, this._requestLogHandler); |
Author
There was a problem hiding this comment.
Just realized it may be possible that these produce duplicate events if registered more than once. Will need to double check on that.
Author
There was a problem hiding this comment.
Turns out it would create duplicates. I've fixed and added a test to verify this doesn't happen.
Author
|
We've moved this to our fork at https://github.com/elastic/good |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows consumer apps to reconfigure and restart good's monitor on the fly. This is useful for supporting logrotate (allows our application to handle SIGHUP signals to trigger reopening of files) and supporting on-the-fly configuration changes.
We're using this in https://github.com/elastic/kibana and think it's a useful addition to all users of good. I've included updated tests and documentation. Happy to take feedback and tweaks!