Add expiration update on validate. Add rememberMeFor property.#28
Add expiration update on validate. Add rememberMeFor property.#28phess101 wants to merge 2 commits intohapijs:masterfrom
Conversation
|
+1 |
|
+1. This would be the bee's knees. |
|
Had a look, can't find any issues with it +1 |
|
+1 |
There was a problem hiding this comment.
Need to specify the input type (boolean?)
There was a problem hiding this comment.
This is the expiration time in milliseconds (just like ttl property).
|
Missing tests and full coverage. |
There was a problem hiding this comment.
I don't like this. It's a bit of a hack. Why not just change the set() signature to set(session, ttl) so you can override it per set?
There was a problem hiding this comment.
Makes sense, but to be clear, are you suggesting that the rememberMe logic should be on the validate function? (line 84). Then I'd just be providing the ttl to the set function.
|
I don't like this approach. Replacing it with something similar. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
I needed the ability to update expiration every time the page is accessed (pushing out the expiration ttl time).
Also added Remember Me functionality.