Skip to content

Drop support for node v12 and hapi v18#244

Closed
devinivy wants to merge 1 commit intov12from
drop-node-12
Closed

Drop support for node v12 and hapi v18#244
devinivy wants to merge 1 commit intov12from
drop-node-12

Conversation

@devinivy
Copy link
Copy Markdown
Member

In dropping node v12 we should also drop support for hapi v18, which only supported up to node v12.

@devinivy devinivy added the breaking changes Change that can breaking existing code label Mar 29, 2022
@devinivy devinivy added this to the 12.0.0 milestone Mar 29, 2022
Copy link
Copy Markdown
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder, don't we want to also put an engines property on the package.json to clearly indicates that we don't support node < 14?

@kanongil
Copy link
Copy Markdown

There used to be an engines entry on all modules, but it was removed at some point. I can't remember the details, but one issue is that npm completely ignores it unless you installed with the --engine-strict flag, though that might also be broken.

So unless you are using yarn, it is mostly a signal to a human reading the file. I think the official hapi recommendation to figure out which node versions are supported, is to check the CI config. This makes the entry redundant and just complicates module maintenance.

@@ -1,5 +1,5 @@
Copyright (c) 2012-2020, Sideway Inc, and project contributors
Copyright (c) 2012-2014, Walmart.
Copyright (c) 2012-2022, Sideway Inc, and project contributors
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright (c) 2012-2022, Sideway Inc, and project contributors
Copyright (c) 2012-2022, Project contributors
Copyright (c) 2012-2020, Sideway Inc

@Nargonath
Copy link
Copy Markdown
Member

Alright I see, makes sense. Thanks for the detailed explanation @kanongil.

@devinivy
Copy link
Copy Markdown
Member Author

Closed in favor of #246

@devinivy devinivy closed this Jul 19, 2022
@devinivy devinivy deleted the drop-node-12 branch July 19, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changes Change that can breaking existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants