Fix redirectTo function w/ blank to behave like blank redirectTo (fix)#183
Merged
mrlannigan merged 1 commit intohapijs:masterfrom Feb 8, 2018
flippidippi:master
Merged
Fix redirectTo function w/ blank to behave like blank redirectTo (fix)#183mrlannigan merged 1 commit intohapijs:masterfrom flippidippi:master
mrlannigan merged 1 commit intohapijs:masterfrom
flippidippi:master
Conversation
Contributor
Author
|
@mrlannigan looks like there all no conflicts, can we get this merged soon? |
mrlannigan
approved these changes
Feb 8, 2018
Contributor
|
Published with v8.0.1 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #169 pull request. I destroyed it.
Currently when
redirectTois a function and the function returns blank, hapi-auth-cookie stills tries to do the redirect instead of behaving likeredirectTo: undefined. Fixing this will allow issues like #144 where you might want different behavior on an API call vs the browser.This change will allow something like following code to redirect or not according to a header set