Skip to content

Drop session from cache in examples#170

Merged
mrlannigan merged 1 commit intohapijs:masterfrom
lboecker:example
Feb 8, 2018
Merged

Drop session from cache in examples#170
mrlannigan merged 1 commit intohapijs:masterfrom
lboecker:example

Conversation

@lboecker
Copy link
Copy Markdown

No description provided.

@mrlannigan
Copy link
Copy Markdown
Contributor

Hello @superLukas,

First of all thank you for your contribution! Do you mind providing additional detail surrounding why it's important to include a drop call to the cache?

@lboecker
Copy link
Copy Markdown
Author

lboecker commented Dec 13, 2017

The session is dead weight after the user has logged out. Might as well get rid of it. (Unless you explicitly want to keep it around until it expires and your session store deletes it for you.)

@mrlannigan mrlannigan added the documentation Non-code related changes label Jan 20, 2018
@mrlannigan mrlannigan modified the milestones: 8.0.1, 8.1.0 Jan 20, 2018
@mrlannigan mrlannigan merged commit d3e0d83 into hapijs:master Feb 8, 2018
@lboecker lboecker deleted the example branch February 8, 2018 12:31
@mrlannigan
Copy link
Copy Markdown
Contributor

Published with v8.0.1

@lock
Copy link
Copy Markdown

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Non-code related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants