Merged
Conversation
…special Boom.unauthorized
Contributor
|
Hi @dpmott, Thank you for your contribution! Are you able to fix the conflicts? |
Contributor
Author
|
@mrlannigan Sorry for the late response. Updates pushed. |
mrlannigan
suggested changes
Feb 8, 2018
test/index.js
Outdated
| expect(header[0]).to.contain('Max-Age=60'); | ||
| const cookie = header[0].match(/(?:[^\x00-\x20\(\)<>@\,;\:\\"\/\[\]\?\=\{\}\x7F]+)\s*=\s*(?:([^\x00-\x20\"\,\;\\\x7F]*))/); | ||
|
|
||
| server.inject({ method: 'GET', url: '/resource', headers: { cookie: 'first=' + cookie[1] } }, (res2) => { |
Contributor
There was a problem hiding this comment.
Can you add consistency to the way you inject requests? (i.e. use await)
mrlannigan
approved these changes
Feb 8, 2018
Contributor
|
Published with v8.1.0 |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #163
Allow fail-over to secondary auth strategy when validateFunc returns special Boom.unauthorized.
Refer to the Hapi docs:
https://hapijs.com/api#serverauthschemename-scheme
" If the err does not include a message but does include the scheme name (e.g. Boom.unauthorized(null, 'Custom')), additional strategies will be attempted in the order of preference (defined in the route configuration). "