Skip to content

Fix Patch.diff generating malformed patch when adding a line at the end of a file that doesn't end with a newline character#29

Merged
kit-ty-kate merged 2 commits intohannesm:mainfrom
kit-ty-kate:fix-no-newline-add
Jun 2, 2025
Merged

Fix Patch.diff generating malformed patch when adding a line at the end of a file that doesn't end with a newline character#29
kit-ty-kate merged 2 commits intohannesm:mainfrom
kit-ty-kate:fix-no-newline-add

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Collaborator

@kit-ty-kate kit-ty-kate commented May 28, 2025

Fix #28

TODO: add a test

@hannesm
Copy link
Copy Markdown
Owner

hannesm commented May 28, 2025

i don't understand the diff, but thanks for fixing the issue and please merge if you're satisfied

…e end of a file that doesn't end with a newline character
…nd of a file that doesn't end with a newline character
@kit-ty-kate kit-ty-kate force-pushed the fix-no-newline-add branch from 2f4a595 to c3f5bbb Compare June 2, 2025 00:00
@kit-ty-kate kit-ty-kate merged commit e50ab1e into hannesm:main Jun 2, 2025
1 check was pending
@kit-ty-kate kit-ty-kate deleted the fix-no-newline-add branch June 2, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Patch.diff generates a malformed diff when adding a line at the end of a file that doesn't end with a newline character

2 participants