fix: wrap constructor in a factory function so callable from node.js#973
Closed
hburrows wants to merge 1 commit intohammerjs:masterfrom
Closed
fix: wrap constructor in a factory function so callable from node.js#973hburrows wants to merge 1 commit intohammerjs:masterfrom
hburrows wants to merge 1 commit intohammerjs:masterfrom
Conversation
…wser and backend server environments
|
Were running into this issue in our builds. Do you know when this will merge into master? |
|
Is there any "merge into master" activity planned to fix this "no go like" issue ? |
Contributor
|
This PR is not valid any longer the whole structure of the project has changed since this |
|
But . . . oh my . . . |
|
I think it shouldn't be closed, since #930 is still a problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #930. This wraps the constructor in a factory function that is callable from both browser and backend server environments which is necessary for server side rendering (via React, etc.). The implementation uses a jQuery style approach by returning a factory function when
windoworwindow.documentare not available that can be used for later initialization.