Return result of a deferred call#62
Closed
SUNx2YCH wants to merge 1 commit intohamcrest:masterfrom
SUNx2YCH:raises_fix
Closed
Return result of a deferred call#62SUNx2YCH wants to merge 1 commit intohamcrest:masterfrom SUNx2YCH:raises_fix
SUNx2YCH wants to merge 1 commit intohamcrest:masterfrom
SUNx2YCH:raises_fix
Conversation
Author
|
There is an issue with py32 env: |
Author
|
It turns out that pip 8 also dropped support for Python 3.2: travis-ci/travis-ci#5485 |
Member
|
I'm going to revisit Python 2.6 support before merging this. Probably do that this weekend. |
Author
|
BTW, |
Member
|
Thanks, I'll just do the downgrade as part of the merge. |
Member
|
Pushed as 1.9.0 |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my custom matcher based on
RaisesI need a deferred call result to create a meaningful mismatch description (when there was no exception raised). That's why I think thatDeferredCallable.__call__()should have areturnstatement.I'm pretty sure that this change will not break anything.
Also I have removed a couple of unused imports.