Skip to content

Conversation

@akowal
Copy link
Contributor

@akowal akowal commented Jan 22, 2019

Change license name from "BSD Licence 3" to "BSD License 3". This typo
fails automated license checks in a project that has
hamcrest dependency.

Change license name from "BSD Licence 3" to "BSD License 3". This typo
fails automated license checks in a project that has
hamcrest dependency.
@zaphod42
Copy link
Member

This isn't to say that the change should be rejected. I do want to point out that "licence" with a "c" is not a typo. It is an alternative spelling for the word. "License" with and "s" is the American spelling. As this is a project primarly by people in the UK it is understandable the the non-American spelling is used in the project.

@akowal
Copy link
Contributor Author

akowal commented Jan 22, 2019

@zaphod42 In this case it's not about spelling difference. It is a typo since correct name of the license is BSD License as per LICENSE.TXT.

@sf105 sf105 merged commit 885fd9d into hamcrest:master Jan 22, 2019
@sf105
Copy link
Member

sf105 commented Jan 22, 2019

Accepted. For curiosity, what is the check that’s running?

@akowal
Copy link
Contributor Author

akowal commented Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants