Skip to content

feat: add verison parameter for component resources#22

Merged
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom
ruibaby:feat/add-version-param
Oct 30, 2023
Merged

feat: add verison parameter for component resources#22
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom
ruibaby:feat/add-version-param

Conversation

@ruibaby
Copy link
Copy Markdown
Member

@ruibaby ruibaby commented Oct 29, 2023

为搜索组件资源添加版本号,防止升级之后无法及时更新缓存。

/kind improvement

为搜索组件资源添加版本号,防止升级之后无法及时更新缓存。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 29, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and guqing October 29, 2023 08:06
Copy link
Copy Markdown
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread src/main/java/run/halo/search/widget/SearchWidgetHeadProcessor.java
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 7390bfa into halo-dev:main Oct 30, 2023
@ruibaby ruibaby deleted the feat/add-version-param branch October 30, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants