refactor: use lit element to refactor search component#18
Merged
ruibaby merged 6 commits intohalo-dev:mainfrom Oct 25, 2023
Merged
refactor: use lit element to refactor search component#18ruibaby merged 6 commits intohalo-dev:mainfrom
ruibaby merged 6 commits intohalo-dev:mainfrom
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
JohnNiang
approved these changes
Oct 25, 2023
Member
JohnNiang
left a comment
There was a problem hiding this comment.
It works very well.
The final transfer size of JS is 12.2KB.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
使用 Lit 重构搜索组件，可以获得更小的体积，并且提高可移植性，用于任何 JS 框架。
/kind improvement
Fixes #17
TODO:
可测试 JAR 包：plugin-search-widget-1.0.0-SNAPSHOT.jar.zip
Review 建议直接查看：https://github.com/halo-dev/plugin-search-widget/tree/main/packages/search-widget/src