Revert: refresh the plugin wrapper when starting the plugin#5238
Merged
f2c-ci-robot[bot] merged 1 commit intohalo-dev:mainfrom Jan 24, 2024
Merged
Conversation
… starting Signed-off-by: John Niang <johnniang@foxmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5238 +/- ##
============================================
+ Coverage 57.05% 57.08% +0.03%
Complexity 3332 3332
============================================
Files 584 584
Lines 19191 19179 -12
Branches 1445 1445
============================================
Hits 10949 10949
+ Misses 7666 7654 -12
Partials 576 576 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.12.x
What this PR does / why we need it:
This PR reverts changes in PR #4023, mainly thanks to PR #5148.
We don't need to refresh the plugin wrapper on every startup, because we entirely disable the plugin in plugin manager when disabling plugin at console.
Which issue(s) this PR fixes:
Fixes #4016
Does this PR introduce a user-facing change?