Merged
Conversation
For the timer function to work correctly, the data type cannot be "int" because it overflows, but must be "unsigned long" just like the variable "millis()"
For the timer function to work correctly, the data type cannot be "int" because it overflows, but must be "unsigned long" just like the variable "millis()"
For the timer function to work correctly, the data type cannot be "int" because it overflows, but must be "unsigned long" just like the variable "millis()"
Owner
|
Thanks for fixing the error. |
Contributor
Author
|
Hi Hafidhh Regards Hugo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Hafidhh
I have tested your library on an Arduino Leonardo Board, more exactly and Arduino Things Uno Board based on Arduino Leonardo architecture, and interrupt has not been working.
Researching for possible causes, i found that Interrupt Pin versus Interrupt Number, is not fixed on all boards, and arduino recommend to use the translation funcion attachInterrupt(digitalPinToInterrupt(this->_pin) as mentionated here https://www.arduino.cc/reference/en/language/functions/external-interrupts/attachinterrupt/
I tested now and is working!
I hope this can help other users.
Best Regards
@hugojorgemuller